Review Request: activities dataengine

[Chani Armitage]

> On 2010-10-28 18:45:00, Albert Astals Cid wrote:
> > Which of the strings you add here will be shown to the user?

none... unless some plasmoid decides to dump the raw data straight to widgets (which would be dumb in this case) or they're using plasmaengineexplorer (in which case they're a developer and probably want to know the literal strings).

so maybe I shouldn't have messages.sh after all?


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5707/#review8414
-----------------------------------------------------------


On 2010-10-28 17:09:34, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5707/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 17:09:34)
> 
> 
> Review request for Plasma and Albert Astals Cid.
> 
> 
> Summary
> -------
> 
> this is a basic activities dataengine. no frills to start with, just a source for each activity.
> the service allows setting the current activity (other features, like setting an activity's name, can be added later).
> it uses KActivityController and friends internally.
> 
> I'm not sure if I got the i18n right, though - I can't remember how that works for dataengines.
> 
> 
> Diffs
> -----
> 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.h 1188056 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.cpp 1188056 
>   trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1188056 
> 
> Diff: http://svn.reviewboard.kde.org/r/5707/diff
> 
> 
> Testing
> -------
> 
> I've updated the ActivityBar plasmoid to use the engine, and it works with no regressions :)
> 
> 
> Thanks,
> 
> Chani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101028/5a78683f/attachment.htm