Review Request: Added System Wallpaper and My Downloaded Wallpaper checkboxes to sildeshow config

Jeremy Whiting jpwhiting at kde.org
Thu Oct 28 17:23:04 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5705/
-----------------------------------------------------------

Review request for Plasma and Davide Bettio.


Summary
-------


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1190556 
  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1189844 
  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui 1189844 

Diff: http://svn.reviewboard.kde.org/r/5705/diff


Testing
-------

I works quite well actually.  I still think we need to disable the apply and ok buttons when no checkbox is checked and no paths are in the listbox, but we work around that by putting the system folder in the list if there are no folders in the kconfig.


Thanks,

Jeremy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101028/f53c19c4/attachment.htm 


More information about the Plasma-devel mailing list