Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

[Mohit Kothari]

> On 2010-10-21 15:39:47, Marco Martin wrote:
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp, line 469
> > <http://svn.reviewboard.kde.org/r/5679/diff/2/?file=39870#file39870line469>
> >
> >     here we use brackets also for one line ifs
> >     if () {
> >     
> >     } else {
> >     
> >     }

Thnx for the if else one....as i am of the habit of not including braces in one liners

As for obscure one we can insert an encrypted one using any of the encryption available but since being opensource storing passwords in text file is vulnerable so i think that was the reason it was removed if it was (i dnt know abt the later).


- Mohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5679/#review8290
-----------------------------------------------------------


On 2010-10-21 18:19:51, Mohit Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5679/
> -----------------------------------------------------------
> 
> (Updated 2010-10-21 18:19:51)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> It was a bug posted on bugs.kde.org,
> Here is the link: https://bugs.kde.org/show_bug.cgi?id=242377
> Well it did stored the password in config file but never read it.
> So i just added the reading feature and reloaded the history.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp 1188219 
> 
> Diff: http://svn.reviewboard.kde.org/r/5679/diff
> 
> 
> Testing
> -------
> 
> I tested it on kdeplasma-addons revision 1187571
> 
> 
> Thanks,
> 
> Mohit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101021/2a76eac7/attachment-0001.htm