Review Request: Adding filename as tooltip for frame applet

[Sujith H]

> On 2010-10-20 17:24:50, Ingomar Wesp wrote:
> > I'm not the maintainer of the applet, so I'm sorry that I can only comment on the code itself, not on whether it should go into the applet.
> > 
> > I noticed a few issues:
> > - The includes are still in the header. Since you've removed the member variable, you can remove them as well.
> > - The user visible text "File:" you're setting as main text needs to go through i18n.
> > - You're setting the tooltip content twice (the first call to ToolTipManager::setContent is unnecessary IMHO).
> >

Ok, I can understand that. 

-I had removed the changes in the header file. Now when I do 'svn status' in my working machine, I can find only frame.cpp file updated.
-I had changed the "File:" to i18n.
-My mistake removed the first call to ToolTipManager::setContent


- Sujith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5660/#review8275
-----------------------------------------------------------


On 2010-10-20 15:47:47, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5660/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 15:47:47)
> 
> 
> Review request for Plasma and Anne-Marie Mahfouf.
> 
> 
> Summary
> -------
> 
> Added the filename as tooltip for the frame applet. The filename will be displayed as the
> tooltip when the user moves the moves on the frame.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 
> 
> Diff: http://svn.reviewboard.kde.org/r/5660/diff
> 
> 
> Testing
> -------
> 
> Tested on the set of pictures I had in my laptop.
> 
> 
> Thanks,
> 
> Sujith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101020/ee46368e/attachment-0001.htm