Review Request: Added bool PopupApplet::isIconified() const method

Marco Martin notmart at gmail.com
Tue Oct 19 22:00:09 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5666/#review8245
-----------------------------------------------------------

Ship it!


to me is fine


/trunk/KDE/kdelibs/plasma/popupapplet.h
<http://svn.reviewboard.kde.org/r/5666/#comment8503>

    @since 4.6


- Marco


On 2010-10-19 19:50:04, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5666/
> -----------------------------------------------------------
> 
> (Updated 2010-10-19 19:50:04)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Applets sometimes need to know whether they are in a collapsed/iconified mode.
> 
> For example, the folderview and shelf applets would be able to allow the user to set the icon for the applet only when they are iconified since it doesn't make sense when they are not.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/popupapplet.h 1187498 
>   /trunk/KDE/kdelibs/plasma/popupapplet.cpp 1187498 
> 
> Diff: http://svn.reviewboard.kde.org/r/5666/diff
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Ivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101019/1e4a5e93/attachment-0001.htm 


More information about the Plasma-devel mailing list