Review Request: Startup Feedback KWin Effect

[Martin Gräßlin]

> On 2010-10-05 11:26:28, Lubos Lunak wrote:
> > The KRunner detour is unnecessary, KWin doesn't need to be told by KRunner things it can find out on its own. It'd be cleaner to just have the KWin effect use KSelectionOwner to claim a manager selection and KRunner would not do anything when it finds something else is already handling the feedback.
> > 
> > Also, as for the 'TODO: optimize', it would be nice to at least limit this to a reasonably sized rectangle instead of full repaints, if it's non-trivial to get the exact size.

Ok, will change to KSelectionOwner and handle everything from inside the effect. Of course I wanted to set a reasonable repaint size before committing. Problem so far seems to be the moving mouse. The trackmouse effect solves that problem by polling for position changes and adding repaints, so I probably do the same


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5529/#review7973
-----------------------------------------------------------


On 2010-10-05 10:27:09, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5529/
> -----------------------------------------------------------
> 
> (Updated 2010-10-05 10:27:09)
> 
> 
> Review request for kwin, Plasma and Lubos Lunak.
> 
> 
> Summary
> -------
> 
> Implemented an OpenGL based Startup Feedback effect to replace the functionality provided by StartupId in KRunner when effects are available. The effect supports the three modes bouncing, blinking and passive in exactly the same way as the current existing functionality.
> 
> Using an effect has several advantages:
>  * we do not need to remove the alpha channel from the icons
>  * no need to move windows around, shape and raise them
>  * no need to prepare several pixmaps for blinking mode as OpenGL provides the same functionality using texture modulation (have I ever mentioned that I hate texture modulation?)
> 
> The effect is completely controlled by KRunner through DBus, when a startup is added the effect get's activated, when the last current startup is removed the effect gets deactivated again. The DBus call has to pass the type (bouncing, blinking or passive) and the icon name to the effect.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/krunner/startupid.h 1182634 
>   trunk/KDE/kdebase/workspace/krunner/startupid.cpp 1182634 
>   trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1182656 
>   trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.desktop PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5529/diff
> 
> 
> Testing
> -------
> 
> * StartupId uses KWin effect when effect is present
> * Changing mode works
> * StartupId uses "legacy" window when effect is not present.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101005/800cc3b1/attachment.htm