Review Request: Do not use tree view for categories in the vertical widgets explorer
Anselmo L. S. Melo
anselmo.melo at openbossa.org
Sat Oct 2 17:11:56 CEST 2010
> On 2010-10-01 17:20:56, Aaron Seigo wrote:
> > much nicer.
Commited in r1181683. Thanks.
- Anselmo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5446/#review7929
-----------------------------------------------------------
On 2010-09-27 10:57:33, Anselmo L. S. Melo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5446/
> -----------------------------------------------------------
>
> (Updated 2010-09-27 10:57:33)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> The propose here is to remove the Tree View used in the widgets explorer in vertical orientation. In its place, use the same button of the horizontal orientation, what simplifies the code (removes a class and some checks) and improves the use of space as the widgets list can grow vertically.
>
> Better if combined with http://reviewboard.kde.org/r/4676/ as we also gain the space currently occupied by the arrow buttons and the close button in the bottom left corner.
>
> The screenshots attached show the current widget explorer with the categories tree view and the proposed one, using the categories button.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h 1179288
> /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp 1179288
>
> Diff: http://svn.reviewboard.kde.org/r/5446/diff
>
>
> Testing
> -------
>
> Tested in both horizontal and vertical orientations.
>
>
> Screenshots
> -----------
>
> current widgets explorer
> http://svn.reviewboard.kde.org/r/5446/s/511/
> proposed, not using the tree view
> http://svn.reviewboard.kde.org/r/5446/s/512/
>
>
> Thanks,
>
> Anselmo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101002/70dd182f/attachment.htm
More information about the Plasma-devel
mailing list