Review Request: allow SVGs to use systemcolors

[Marco Martin]

> On 2010-09-30 13:10:03, Marco Martin wrote:
> > /trunk/KDE/kdelibs/plasma/svg.cpp, line 441
> > <http://svn.reviewboard.kde.org/r/5495/diff/1/?file=38739#file38739line441>
> >
> >     so the coloring of the pixmap is still kept as retrocompatibility?
> 
> Manuel Mommertz wrote:
>     I don't want to break existing themes ;)

agree.


> On 2010-09-30 13:10:03, Marco Martin wrote:
> > /trunk/KDE/kdelibs/plasma/theme.cpp, line 790
> > <http://svn.reviewboard.kde.org/r/5495/diff/1/?file=38741#file38741line790>
> >
> >     the button widget should be modified if this will start to be used
> 
> Manuel Mommertz wrote:
>     For what reason?

i see on hover events the pushbutton searches for an "active" element (not even used anymore by the default theme btw), so if that element uses ButtonHoverColor should already e possible to color it


> On 2010-09-30 13:10:03, Marco Martin wrote:
> > /trunk/KDE/kdelibs/plasma/theme.cpp, line 320
> > <http://svn.reviewboard.kde.org/r/5495/diff/1/?file=38741#file38741line320>
> >
> >     i wonder how much is the benefit vs cost of caching this?
> 
> Manuel Mommertz wrote:
>     Both is quite low. ;) But as this stylesheet has to be generated for every Plasma::Svg object, which is 259 times for a start of plasma with the default setup + analog clock + calculator, it feels wrong to regenerate it that often.

ok


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/#review7905
-----------------------------------------------------------


On 2010-10-01 14:25:03, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5495/
> -----------------------------------------------------------
> 
> (Updated 2010-10-01 14:25:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> With this patch applied SVGs can put a style-element with id 'current-system-colors' in it, which gets replaced by a style with the current systemcolors. This allows SVGs to use colors like background color and text color from the system palette. Giving themes much more possibilitys then just coloring the resulting pixmap.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/theme.h 1180314 
>   /trunk/KDE/kdelibs/plasma/theme.cpp 1180314 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 1180314 
> 
> Diff: http://svn.reviewboard.kde.org/r/5495/diff
> 
> 
> Testing
> -------
> 
> Changing theme, changing colorscheme
> 
> 
> Screenshots
> -----------
> 
> Default Colorscheme
>   http://svn.reviewboard.kde.org/r/5495/s/520/
> green-gray Colorscheme
>   http://svn.reviewboard.kde.org/r/5495/s/522/
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101001/84300933/attachment.htm