Review Request: allow SVGs to use systemcolors

Manuel Mommertz 2kmm at gmx.de
Fri Oct 1 16:25:03 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/
-----------------------------------------------------------

(Updated 2010-10-01 14:25:03.138571)


Review request for Plasma.


Summary
-------

With this patch applied SVGs can put a style-element with id 'current-system-colors' in it, which gets replaced by a style with the current systemcolors. This allows SVGs to use colors like background color and text color from the system palette. Giving themes much more possibilitys then just coloring the resulting pixmap.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/theme.h 1180314 
  /trunk/KDE/kdelibs/plasma/theme.cpp 1180314 
  /trunk/KDE/kdelibs/plasma/svg.cpp 1180314 

Diff: http://svn.reviewboard.kde.org/r/5495/diff


Testing
-------

Changing theme, changing colorscheme


Screenshots (updated)
-----------

Default Colorscheme
  http://svn.reviewboard.kde.org/r/5495/s/520/
green-gray Colorscheme
  http://svn.reviewboard.kde.org/r/5495/s/522/


Thanks,

Manuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101001/6cc9e1c9/attachment.htm 


More information about the Plasma-devel mailing list