Review Request: Fix PaintUtils::shadowText() placement

Christoph Feck christoph at maxiom.de
Fri Oct 1 04:00:07 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5504/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

I used Plasma::PaintUtils::shadowText() to draw a text halo (offset 0,0) around a text.
Unfortunately, that halo got cropped (see the "g").

This patch should
* fix placement of shadow and text inside the resulting pixmap
* fix "addSize" not enlarged for negative offsets
* simplify computation


Diffs
-----

  /trunk/KDE/kdelibs/plasma/paintutils.cpp 1181424 

Diff: http://svn.reviewboard.kde.org/r/5504/diff


Testing
-------


Screenshots
-----------

before
  http://svn.reviewboard.kde.org/r/5504/s/517/
after
  http://svn.reviewboard.kde.org/r/5504/s/519/


Thanks,

Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101001/11f9759a/attachment.htm 


More information about the Plasma-devel mailing list