Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9051
-----------------------------------------------------------

Ship it!


Have you tried removing the space again after you've changed the font? That way it would be transparent I think.

Otherwise, patch is OK from my POV. When you've filed a Qt bug, please put a reference URL to it in the code, as it's a bit "unusual" and easier to keep track that way.


trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp
<http://svn.reviewboard.kde.org/r/6005/#comment9845>

    use toPlainText().isEmpty() here


- Sebastian


On 2010-11-28 20:23:45, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 20:23:45)
> 
> 
> Review request for Plasma and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> Text format of the note can't be changed while the note is empty, so I add a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 
>   trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 
> 
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101130/0cdc2d55/attachment.htm