Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty
Anne-Marie Mahfouf
annma at kde.org
Tue Nov 30 13:14:16 CET 2010
> On 2010-11-30 01:04:03, Davide Bettio wrote:
> > Should we apply this patch while waiting someone who fix this bug in Qt?
>
> Aaron Seigo wrote:
> sure (if only because the bug has been closed as "out of scope"), but annotate the code with a comment explaining the situation and a link to the bug report on the qt bug tracker.
>
> Stephen Kelly wrote:
> Just for clarity, I think it's similar to the bug I filed with Qt before, but maybe not the same.
>
> I think you should file a new Qt bug and link to that.
Stephen did you investigate further? I can't reproduce on a test case i.e. if I have an empty QTextEdit and set bold then the first char is bold. Same if I use the example TextEdit and click NEw and set Bold then the first char is bold.
Is there a reason why you point to Qt and can you explain it so I can make a test case?
- Anne-Marie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9050
-----------------------------------------------------------
On 2010-11-28 20:23:45, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
>
> (Updated 2010-11-28 20:23:45)
>
>
> Review request for Plasma and Stephen Kelly.
>
>
> Summary
> -------
>
> Text format of the note can't be changed while the note is empty, so I add a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire.
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054
>
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Davide
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101130/a3ed728a/attachment.htm
More information about the Plasma-devel
mailing list