Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

[Aaron Seigo]

> On 2010-11-30 01:04:03, Davide Bettio wrote:
> > Should we apply this patch while waiting someone who fix this bug in Qt?

sure (if only because the bug has been closed as "out of scope"), but annotate the code with a comment explaining the situation and a link to the bug report on the qt bug tracker.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9050
-----------------------------------------------------------


On 2010-11-28 20:23:45, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 20:23:45)
> 
> 
> Review request for Plasma and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> Text format of the note can't be changed while the note is empty, so I add a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review request also steveire.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 
>   trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 
> 
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101130/51ce8f92/attachment.htm