Review Request: Turns the slide effect off if KRunner is set to floating.

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6006/
-----------------------------------------------------------

(Updated 2010-11-29 22:22:14.795984)


Review request for kwin and Plasma.


Changes
-------

Implements what Martin suggested, or at least I think so. :)
Seems to work nicely.


Summary
-------

Turns the slide effect off if floating is used. This is related to BUG:218678 but does not completely fix it.

Steps to reproduce:
1. set krunner to top screen, hide/show it
2. set krunner to floating
3. hide it
4. show it

Step 3 and 4 use the slide-animation that should only be used if it is at the top.
This patch fixes this behavior to some degree.

Now only step three will use the slide animation and from that point on the correct one will be used.
I am not sure how I can also fix step 3, help welcome! :)


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1202160 
  /trunk/KDE/kdebase/workspace/kwin/effects/slidingpopups/slidingpopups.cpp 1202160 

Diff: http://svn.reviewboard.kde.org/r/6006/diff


Testing
-------


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101129/ebe3bae0/attachment.htm