Review Request: Display applet context menu when the label hasn't any context menu to show.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6009/#review9040
-----------------------------------------------------------

Ship it!


i think it could work. let's see how it goes


trunk/KDE/kdelibs/plasma/widgets/label.cpp
<http://svn.reviewboard.kde.org/r/6009/#comment9792>

    i wonder if should be necessary to check some other flag like linkaccessiblebymouse..
    in general it could work.


- Marco


On 2010-11-29 16:24:16, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6009/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 16:24:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If there isn't any label context menu to show the event is ignored. It makes sense to show a context menu only when the text can be selected or when there is a link.
> This patch improves usability of applets which they have a lot of labels (like the weather plasmoid) or applets with huge labels (like the calculator).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/label.cpp 1202069 
> 
> Diff: http://svn.reviewboard.kde.org/r/6009/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101129/bad7a752/attachment.htm