Review Request: The KSystemActivityDialog uses MB as default unit.

Sebastian Kügler sebas at kde.org
Mon Nov 29 16:50:27 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6007/#review9038
-----------------------------------------------------------


The unit used should probably be the global KDE setting, as described in:

http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKLocale.html#a42d678b641fde94ba12b89e4e4472a83

I'm myself not really happy with the MiB notation, because it's less commonly understood, setting this on a per-application basis seems wrong, still.

- Sebastian


On 2010-11-28 23:31:11, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6007/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 23:31:11)
> 
> 
> Review request for Plasma, Aaron Seigo and John Tapsell.
> 
> 
> Summary
> -------
> 
> The KSystemActivityDialog uses MB as default unit.
> BUG:222022
> 
> 
> This addresses bug 222022.
>     https://bugs.kde.org/show_bug.cgi?id=222022
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/ksystemactivitydialog.cpp 1201754 
> 
> Diff: http://svn.reviewboard.kde.org/r/6007/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101129/9aec7d88/attachment.htm 


More information about the Plasma-devel mailing list