The KWin Coding Style Situation

Martin Gräßlin kde at martin-graesslin.com
Sun Nov 28 20:20:33 CET 2010


Hi,

CC-int Plasma as I would like to get some opinion on it.

From various discussion on IRC and looking through review requests, it seems 
that we have a general problem with our coding style.
 * The coding style is only used in KWin
 * Developers seem to have problems with it, nobody really knows how the style 
should look like (I think I mostly get it, but only mostly)
 * The coding style is not consistent

Personally I see this as a unneeded barrier to get into KWin development. 
Because of that I think we have to do something about it. For me the actual 
coding style does not matter as long as it's consistent - but that is not the 
case.

So I would propose the following:
1. Follow the rules from Plasma concerning coding style (and all other 
development matters - reviews, git, mergin...)
2. Switch to new coding style together with git migration (December, 20th)
3. Reformat complete code base except clients with new coding style and submit 
this to a new branch. Merge it with master after let's say two weeks

Thoughts on that? What I dislike about step 3 is that this would make 
bisecting in future more difficult. But I see it as the only sane way to get a 
consistent coding style.

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 316 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20101128/c1be07b8/attachment.sig 


More information about the Plasma-devel mailing list