Review Request: Supports KDE3 way of starting man/info-pages
Aaron Seigo
aseigo at kde.org
Sat Nov 27 19:35:42 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5985/#review9008
-----------------------------------------------------------
Ship it!
the logic looks fine, but calling it "kde3Shortcut" is not a great name. it implies knowing what kde3 was doing and doesn't actually describe what the code is attempting to do at all (man/info lookups). please replace it with a descriptive name before committing.
- Aaron
On 2010-11-27 16:57:02, Matthias Fuchs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5985/
> -----------------------------------------------------------
>
> (Updated 2010-11-27 16:57:02)
>
>
> Review request for Plasma and Teemu Rytilahti.
>
>
> Summary
> -------
>
> Supports KDE3 of starting man-pages (#term) and info-pages (##term).
> This is way faster than typing "man:" or "info:".
> BUG:200556
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/locations/locationrunner.cpp 1200935
>
> Diff: http://svn.reviewboard.kde.org/r/5985/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matthias
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101127/399dccf6/attachment.htm
More information about the Plasma-devel
mailing list