Review Request: [4.7] Makes it possible to specify the language spell check runner should use, e.g. "spell_de $TERM".

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5849/#review8736
-----------------------------------------------------------


is there a need for the underscore, or for being able to configure it? would it be enough to just check if there is more than one word after "spell", check if that's a valid dictionary and if so use it? that would lead to imho the more natural grammar of "spell hello", "spell en hello", "spell de Kraul". 

being able to write "spell german Kraul" would be really nice (prevents the user from having to know the language codes) but perhaps asking too much from the runner :)

- Aaron


On 2010-11-15 12:45:41, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5849/
> -----------------------------------------------------------
> 
> (Updated 2010-11-15 12:45:41)
> 
> 
> Review request for Plasma and Ryan Bitanga.
> 
> 
> Summary
> -------
> 
> Feature for 4.7
> 
> As the summary says, this patch allows to define which dictionary the spell check runner should use. "spell" will always use the default one.
> "spell_de" or more specifically "spell_de_DE" would work now.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.h 1197278 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp 1197278 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.h 1197278 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.cpp 1197278 
>   /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck_config.ui 1197278 
> 
> Diff: http://svn.reviewboard.kde.org/r/5849/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101115/650e737a/attachment.htm