Review Request: Spell checker runner displays a warning if no valid dictornary could be used
Aaron Seigo
aseigo at kde.org
Mon Nov 15 02:03:44 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5847/#review8727
-----------------------------------------------------------
Ship it!
small whitespace fix needed, but otherwise looks good.
/trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp
<http://svn.reviewboard.kde.org/r/5847/#comment9283>
fix indentation
- Aaron
On 2010-11-15 00:07:55, Matthias Fuchs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5847/
> -----------------------------------------------------------
>
> (Updated 2010-11-15 00:07:55)
>
>
> Review request for Plasma and Ryan Bitanga.
>
>
> Summary
> -------
>
> If no valid dictionary is specified the spell checker runner will always display that the word is correct.
> This patch changes it.
> BUG:245453
>
> NOTE: This patch adds two new i18n strings, so I am not sure if this should go into 4.6 or rather 4.7.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/runners/spellchecker/spellcheck.cpp 1196911
>
> Diff: http://svn.reviewboard.kde.org/r/5847/diff
>
>
> Testing
> -------
>
> Tried without any spelling dictionaries installed and the warning was displayed.
> If dictionaries are installed the warning will not be displayed after restarting krunner.
>
>
> Thanks,
>
> Matthias
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101115/feb39941/attachment-0001.htm
More information about the Plasma-devel
mailing list