Review Request: Launchersupport in the Tasks-applet

[Todd]

> On 2010-11-09 21:11:41, Todd wrote:
> > Might it be a good idea to make tasks that have a launcher associated with them somehow visually distinct from those that don't?
> 
> Anton Kreuzkamp wrote:
>     If you give me an idea how to indicate that a task has a launcher I can do (it should be decent)

I'm not sure in this specific case, perhaps a different color, a stronger highlight, or a double outline.  Would it be possible to have an optional theme element that could be used for tasks that have a launcher, and fall back to the normal task element otherwise?  Also, is the appearance of the launcher itself themable?


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5786/#review8599
-----------------------------------------------------------


On 2010-11-09 20:56:40, Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5786/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 20:56:40)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Implementation of the launchersupport in plasma's "Tasks"-applet. It depends on http://svn.reviewboard.kde.org/r/5785/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/CMakeLists.txt 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1193890 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1193890 
> 
> Diff: http://svn.reviewboard.kde.org/r/5786/diff
> 
> 
> Testing
> -------
> 
> tested, everything worked well so far.
> 
> 
> Screenshots
> -----------
> 
> Add a launcher via context menu
>   http://svn.reviewboard.kde.org/r/5786/s/553/
> How the launcher look like (+ tooltip)
>   http://svn.reviewboard.kde.org/r/5786/s/554/
> The launcher isn't shown when the application is running
>   http://svn.reviewboard.kde.org/r/5786/s/555/
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101110/ed23f9fd/attachment.htm