Review Request: Plasma: Folder View: Icon displays 'pressed' on non-activating clicks

[Markus Slopianka]

> On 2010-11-09 18:37:25, Aaron Seigo wrote:
> >
> 
> Lindsay Roberts wrote:
>     If there are no objections could I request that someone check this in?

Does it change the behavior described in https://bugs.kde.org/show_bug.cgi?id=256465 (always using the large 256x256 icon for the scaling effect)?
If no, I suggest to tweak the patch because ever since Nuno changed the hi-res icons to look completely different from the smaller ones, the scaling effect looks really weird.


- Markus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5805/#review8589
-----------------------------------------------------------


On 2010-11-09 11:50:55, Lindsay Roberts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5805/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 11:50:55)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The folder view employs a 'pressed' effect to show when an icon is activated.
> This works as expected when global settings are set to single click: the icon
> is scaled to 90% on press, and rescales back up on activate.
> 
> Under double click the icon scales on the first click, and weirdly stays scaled
> until the mouse leaves the hover area.
> 
> Further, the same issue applies when modifier keys are used to change
> selection.
> 
> 
> This addresses bug 256297.
>     https://bugs.kde.org/show_bug.cgi?id=256297
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1193797 
> 
> Diff: http://svn.reviewboard.kde.org/r/5805/diff
> 
> 
> Testing
> -------
> 
> Tested with both single and double click settings.
> 
> 
> Thanks,
> 
> Lindsay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101110/125c29db/attachment.htm