Review Request: Tasks applet: Make order independent of whether the row count is forced.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5776/#review8529
-----------------------------------------------------------

Ship it!


looks good; thanks for the further explanation. i missed that the col/row counts were already being computed elsewhere in the code appropriately.

- Aaron


On 2010-11-06 20:58:47, Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5776/
> -----------------------------------------------------------
> 
> (Updated 2010-11-06 20:58:47)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This should fix <https://bugs.kde.org/show_bug.cgi?id=215231>, but frankly I don't understand why it was done this way in the first place...
> 
> 
> This addresses bug 215231.
>     https://bugs.kde.org/show_bug.cgi?id=215231
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1190987 
> 
> Diff: http://svn.reviewboard.kde.org/r/5776/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 3 forced rows, 1-5 windows, trunk vs. patched
>   http://svn.reviewboard.kde.org/r/5776/s/550/
> 
> 
> Thanks,
> 
> Ingomar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101107/3eb0a0ae/attachment-0001.htm