Review Request: Tasks applet: Make order independent of whether the row count is forced.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5776/#review8522
-----------------------------------------------------------


it's probably that way so that if you say "two rows" then you get two rows even there are only two buttons. otherwise you'll get a whole row of buttons that takes up just the top row before filling in the rows below, leaving a large section of the widget empty until the rows are filled in with entries.

[ window ]
[ window ]

vs

[ window ] [ window ]
<      empty        >

on the other hand, trying to keep a stable # of rows while distributing between the rows would result in entries moving around quite a bit as windows are added .. which also isn't good.

could you take some screenshots of the tasks widget running with your patch with different numbers of rows and windows showing in it, that we can use to get some responses to?

- Aaron


On 2010-11-06 13:09:53, Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5776/
> -----------------------------------------------------------
> 
> (Updated 2010-11-06 13:09:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This should fix <https://bugs.kde.org/show_bug.cgi?id=215231>, but frankly I don't understand why it was done this way in the first place...
> 
> 
> This addresses bug 215231.
>     https://bugs.kde.org/show_bug.cgi?id=215231
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1190987 
> 
> Diff: http://svn.reviewboard.kde.org/r/5776/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ingomar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101106/a8f4f291/attachment.htm