Review Request: Another approach for PackageStructure for multiple paths per entry

Marco Martin notmart at gmail.com
Thu Nov 4 19:41:57 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5765/
-----------------------------------------------------------

(Updated 2010-11-04 18:41:57.139532)


Review request for Plasma and Aaron Seigo.


Changes
-------

* merged with http://svn.reviewboard.kde.org/r/5763
* made sugested changes


Summary
-------

in relation to http://svn.reviewboard.kde.org/r/5763/
i still can't really wrap my mind  on that approach, i still see it workig more like this:
- the list of fallbacks is defined on the prefix
- diffrent platforms would have things in different prefixes, to not have reserved words in the contents/ directory
- another shell can have a packagerc with different prefix paths (before plasma/packageformats/%1rc a plasma-$app/packageformats/%1rc should be looked for)


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/package.cpp 1193070 
  /trunk/KDE/kdelibs/plasma/packagestructure.h 1193070 
  /trunk/KDE/kdelibs/plasma/packagestructure.cpp 1193070 

Diff: http://svn.reviewboard.kde.org/r/5765/diff


Testing
-------

i am not sure the hash still works :/


Thanks,

Marco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101104/58817f39/attachment-0001.htm 


More information about the Plasma-devel mailing list