Review Request: Group to hash tag conversion in KDE Microblog plasmoid

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5749/#review8469
-----------------------------------------------------------

Ship it!



trunk/KDE/kdeplasma-addons/applets/microblog/postwidget.cpp
<http://svn.reviewboard.kde.org/r/5749/#comment8836>

    forwardText could be const


- Aaron


On 2010-11-01 21:51:08, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5749/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 21:51:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Re-denting a post which contains a group-tag results in duplicate posts to the group. This is a major annoyance ( its even mentioned here http://status.net/wiki/Identiquette ). Because people can often forget to do the conversion, let the software do it :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/microblog/postwidget.cpp 1191412 
> 
> Diff: http://svn.reviewboard.kde.org/r/5749/diff
> 
> 
> Testing
> -------
> 
> Works for all groups I could test. The matching is performed by using the regex \w, which matches a word. I'm not sure it matches words with numbers too, but at the same time, all the groups I had the patience to check were composed of alphabetical characters.
> If anyone has some info on this, It'd be nice.
> 
> 
> Thanks,
> 
> Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101102/19de48d7/attachment.htm