Review Request: Make custom colours work on the digital clock again
Alex Merry
kde at randomguy3.me.uk
Mon Nov 1 18:36:07 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored. This re-enables it, and also allows the user to choose a shadow colour.
This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1191270
/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1191270
/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1191270
Diff: http://svn.reviewboard.kde.org/r/5747/diff
Testing
-------
Changing, saving and loading the settings worked in plasmoid-viewer.
Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101101/6c2c10c3/attachment.htm
More information about the Plasma-devel
mailing list