[patch] Fix network monitor colors and stacking

Petri Damstén petri.damsten at gmail.com
Sat May 22 15:00:14 CEST 2010


On Fri, May 21, 2010 at 10:27 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> On May 21, 2010, Petri Damstén wrote:
>> On Fri, May 21, 2010 at 7:27 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
>> > On May 18, 2010, Petri Damstén wrote:
>> >> On Mon, May 17, 2010 at 1:52 PM, Sergey <sergemp at mail.ru> wrote:
>> >> > Problem:
>> >> >  It's very hard to understand on the network monitor plasmoid which
>> >> >  line is download and which is upload speed. They also stack and
>> >> >  this is not really usual for this kind of graphs.
>> >>
>> >> It was stacked before but there were complains that it's hard to read
>> >> what is the value of the top graph, so it was changed to be not
>> >> stacked.
>> >
>> > any update on this, Petri? let's either merge the bits that make sense or
>> > discard this and close https://bugs.kde.org/show_bug.cgi?id=237922
>>
>> Not sure if stacked or not is better. I can live with both. Is it
>
> well, make a decision one way or the other. :) in fact, just do whatever the
> network management plasmoid is doing. there :)
>
>> possible to add graph colors to theme or is it better to just use hard
>> coded colors (current text/background derived colors don't work
>> nicely). Either way colors should be probably same as in Network
>> Management plasmoid new plotter feature.
>
> agreed.

It now has same colors (hard coded) and is stacked like Network
Manager plasmoid. Stacked part of the patch is there so if it seems to
be bad it can be changed by uncommenting one line.

Petri


More information about the Plasma-devel mailing list