Review Request: Reset KRunner dialog size on query launch

Marco Martin notmart at gmail.com
Fri May 21 21:50:09 CEST 2010



> On 2010-05-21 12:42:14, Marco Martin wrote:
> > yes, those are that little annoyance that make the difference :)
> 
> Ignat Semenov wrote:
>     Don't have an SVN account yet; could you commit this for me?
> 
> Ignat Semenov wrote:
>     Ping? Is this committed?

did it a while ago


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4086/#review5796
-----------------------------------------------------------


On 2010-05-21 12:27:30, Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4086/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 12:27:30)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> After launching a query result from KRunner, the dialog size remains the same the next time KRunner window is opened, that is, there is a large results area. However, if you discard the result, the dialog is reset to normal size, that is, no results area at all, which is inconsistent. This very simple patch fixes that.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1128711 
> 
> Diff: http://reviewboard.kde.org/r/4086/diff
> 
> 
> Testing
> -------
> 
> Seems to work fine. Launched a query result, then hit Alt+F2, the default KRunner window appeared.
> 
> 
> Thanks,
> 
> Ignat
> 
>



More information about the Plasma-devel mailing list