Review Request: QuickSand MatchView interface has hardcoded text color

Alex Fiestas alex at eyeos.org
Tue May 18 16:19:17 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4033/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and wilder.


Summary
-------

The MatchView interface of QuickSand (where the found items are displayed as a vertical list) is hardcoding the text color (black), so when switching to a dark color scheme it's unusable.

The patch remove 2 lines, the FIXME and the actual code which hardcode the color.


Diffs
-----

  trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.cpp 1127908 

Diff: http://reviewboard.kde.org/r/4033/diff


Testing
-------

I have test it with Oxygen and coast, the color and background used is the one defined by the schema, so it's ok.


Thanks,

Alex



More information about the Plasma-devel mailing list