Review Request: Fix QuickSand is always showed in the same screen

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4032/#review5717
-----------------------------------------------------------

Ship it!


good catch

- Marco


On 2010-05-18 14:08:02, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4032/
> -----------------------------------------------------------
> 
> (Updated 2010-05-18 14:08:02)
> 
> 
> Review request for Plasma, Aaron Seigo and wilder.
> 
> 
> Summary
> -------
> 
> Quicksand is always showed in the same screen.
> 
> The problem is that QuickSand is calling QWidget::show before KRunnerDialog::positionOnScreen, so when positionOnScreen check if the dialog isVisible, true is always returned (so the screen is never refreshed).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 1127908 
> 
> Diff: http://reviewboard.kde.org/r/4032/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>