Review Request: Fix QuickSand is always showed in the same screen

Alex Fiestas alex at eyeos.org
Tue May 18 15:51:20 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4032/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Quicksand is always showed in the same screen.

The problem is that QuickSand is calling QWidget::show before KRunnerDialog::positionOnScreen, so when positionOnScreen check if the dialog isVisible, true is always returned (so the screen is never refreshed).


Diffs
-----

  trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp 1127908 

Diff: http://reviewboard.kde.org/r/4032/diff


Testing
-------


Thanks,

Alex



More information about the Plasma-devel mailing list