Review Request: Plasma-themed CSS

[Sebastian Kügler]

On Tue May 11 2010 05:01:24 Aaron Seigo wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3953/#review5579
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> it's unfortunate that we can't define some set parameters that could be
> used in custom stylesheets, but it seems CSS is a bit wonky that way and
> requires styles to be applied to known elements ... which means this kind
> of search-n-replace :/ oh well ... it's a useful feature for making things
> look proper. in it goes :)

That's why I've only included body as top-level item. The design as such 
allows for custom stylesheets though, so it's easy to implement the elements 
you need yourself.

> /trunk/KDE/kdelibs/plasma/theme.cpp
> <http://reviewboard.kde.org/r/3953/#comment5262>
> 
>     should have a space there: foreach (const QString &k; could also be
> done with a QHashIterator, but that's a 6-of-one-half-dozen-of-another
> kind of thing..

I've kept the foreach for now, as it's only a couple of items anyway.

Patch was committed this morning. Thanks for the review! :-)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9