Review Request: Don't show dictionary tooltip when not collapsed

Aaron Seigo aseigo at kde.org
Sat May 8 08:12:19 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3923/#review5510
-----------------------------------------------------------

Ship it!


another nice patch; keep this up and we'll have to hook you up with an svn account of your own :)

- Aaron


On 2010-05-08 05:43:21, David Benjamin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3923/
> -----------------------------------------------------------
> 
> (Updated 2010-05-08 05:43:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Like the weather applet, the dictionary applet should not show a tooltip when placed on the desktop. It's distracting, particularly with the animation, and we already know it's a dictionary. :-)
> 
> 
> This addresses bug 232763.
>     https://bugs.kde.org/show_bug.cgi?id=232763
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/dict/dict.cpp HEAD 
> 
> Diff: http://reviewboard.kde.org/r/3923/diff
> 
> 
> Testing
> -------
> 
> Tested with dictionary applet in both panel and desktop. Been running for past couple of months.
> 
> 
> Thanks,
> 
> David
> 
>



More information about the Plasma-devel mailing list