Review Request: Use the same code to draw animated hovers as normal icons

David Benjamin davidben at mit.edu
Sat May 8 07:37:42 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3921/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

QIcon::paint does some alignment work which we also do in iconRect, but because we also do size snapping and such, the resulting pixmap does not have the same size. This cause annoying bouncing icons because QIcon's default is to center the icon.


This addresses bug 233646.
    https://bugs.kde.org/show_bug.cgi?id=233646


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp HEAD 

Diff: http://reviewboard.kde.org/r/3921/diff


Testing
-------

Been running with this on my main KDE for a while. Tested with Pidgin's icon.


Screenshots
-----------

Screenshot of problem from bug report
  http://reviewboard.kde.org/r/3921/s/386/


Thanks,

David



More information about the Plasma-devel mailing list