Review Request: Stop using oxygen as a theme element fallback before 'default' (Air)

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3903/#review5498
-----------------------------------------------------------


/me seconds Ivan. That's why oxygen was explicitly put as fallback, even if air always was complete.
a theme can explicitly set air as its fallback tough

- Marco


On 2010-05-07 13:17:50, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3903/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 13:17:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If a user starts Plasma on a machine where the configured desktop theme is not available, a fallback is used for each element.  If the theme is completely missing, default fallbacks, in order "oxygen" and "default" are used.  This means that Oxygen elements are used in preference to Air elements.  With common configurations, this results in black text on the black/dark Oxygen elements, which is unusable.
> 
> This patch removes oxygen from the fallbacks, leaving "default" (Air).  Since both oxygen and air are installed by kdebase-workspace they are equally likely to be present.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/theme.cpp 1123666 
> 
> Diff: http://reviewboard.kde.org/r/3903/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will
> 
>