Review Request: Routing (un)mounting error notifications via knotify; part II: dataengine

Jacopo De Simoi wilderkde at gmail.com
Wed May 5 18:10:45 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3896/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.


Summary
-------

This patch provides a dataengine which collects and exposes (un)mounting error notifications; the plasma devicenotifier will spawn an instance of this dataengine to tell knotify that it will display such notifications itself. 


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1123205 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3896/diff


Testing
-------

This patch depends on the corresponding one for knotify;

With that patch it works as expected.


Thanks,

Jacopo



More information about the Plasma-devel mailing list