Review Request: split widget-explorer classes

Chani Armitage chanika at gmail.com
Wed Mar 31 22:12:41 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3470/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this factors out the appletbrowser code into separate classes so that it can be shared with the as-yet-unwritten activity manager UI. I created two new classes, IconList and IconListElement, which AppletsList and AppletIconWidget now inherit.

I think the class names kinda suck, so I'd be fine with renaming them if someone has a better suggestion :) hrm, actually I was thinking of AbstractIconList and AbstractIcon, since both have pure virtuals.

since I haven't actually written the activity manager there'll probably be a bit of code moved around later, but I think it'll stay fairly close to this initial split, and I want to get the code in before any merge conflicts come up.

I haven't attempted to fix any bugs; I just split up the code, and made a note of anything that needs attention later.


Diffs
-----

  /dev/null PRE-CREATION 
  /dev/null PRE-CREATION 
  /dev/null PRE-CREATION 
  /dev/null PRE-CREATION 
  /dev/null PRE-CREATION 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/CMakeLists.txt 1106791 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appleticon.h 1106791 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appleticon.cpp 1106791 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h 1106791 
  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp 1106791 

Diff: http://reviewboard.kde.org/r/3470/diff


Testing
-------

it seems to work as before.
there's just one regression: the tooltips aren't updated on scroll. shouldn't be too hard to fix, just slipped my mind.


Thanks,

Chani



More information about the Plasma-devel mailing list