Review Request: [Picture Frame] Autoupdate function for url's

etienne.rebetez at oberwallis.ch etienne.rebetez at oberwallis.ch
Mon Mar 29 20:08:51 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3334/
-----------------------------------------------------------

(Updated 2010-03-29 18:08:51.127630)


Review request for Plasma.


Changes
-------

In this diff i tryed to concentrate only on the autoupdate function. (So, no download settings, no "messing with classes"  etc. )
Changes where made in the ui, as Aaron suggested.
Cleaned the code from evil withespaces:)

See also Bug 222759 where i changed the download directory to the cache directory.
And Bug 232361 that fixes a crash that happens in the actuall picture frame in trunk. 

Thanks again for your help


Summary (updated)
-------

I was quite happy that the picture frame could handle url's in 4.4. 
So i added the ability to autoupdate the picture with an url periodicaly (i.e. live cams, weather data or <picture that changes over time>).  


Let me know wat you think;)


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1108735 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1108735 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1108735 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1108735 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1108735 

Diff: http://reviewboard.kde.org/r/3334/diff


Testing
-------


Thanks,

eti



More information about the Plasma-devel mailing list