Review Request: again on webview+scrollwidget

[Marco Martin]

> On 2010-03-26 02:38:40, Zack Rusin wrote:
> > Looking good, thanks for taking it all the way! The two whitespace changes should be probably removed. In my initial patch I had that setDragToScroll changed from false to true in webview, I'm not sure if we want to keep that. Does it actually work? Not that it has to, I think Plasma should in general move away from "just working" to trying to answer more fundamental problems like being able to spell out a plum crumble recipe from letters in methods in any given class, but you know it would like a plus if it did work.

yes it didn't work eheh :)
now it's ok in the committed version


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3399/#review4677
-----------------------------------------------------------


On 2010-03-25 21:48:46, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3399/
> -----------------------------------------------------------
> 
> (Updated 2010-03-25 21:48:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is 99% the zack's patch he sent yesterday on mailinglist (using scrollwidget for flicking in webview), it fixes some issues regarding the scrollposition being -widget.position.
> now flicking works again in both cases (with a widget or webview) fixed also ensureItemVisible, wheelevents are a bit better but still a bit wonky
> 
> of course final verdict is from zack ;)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1106404 
>   /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1106402 
> 
> Diff: http://reviewboard.kde.org/r/3399/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>