Review Request: [Picture Frame] Update function for url's and configuration of download path
etienne.rebetez at oberwallis.ch
etienne.rebetez at oberwallis.ch
Sat Mar 27 16:08:02 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3334/
-----------------------------------------------------------
(Updated 2010-03-27 15:08:02.582649)
Review request for Plasma.
Changes
-------
Picture isn't needed anymore.
Summary
-------
I was quite happy that the picture frame could handle url's in 4.4.
So i added the ability to update the picture with an url periodicaly (i.e. live cams, weather data or <picture that changes over time>).
This would be a rather small fix, but i also came accross Bug 222759 and with the updatefunction the download path got quite spamed.
Now it's possible to set the download path and the ability to ovewrite the existing picture when downloaded.
By the way, i also removed the picture class from the slideshow class. The slideshow now manages only the path's and the frame class acceses the picture class directly.
Let me know wat you think;)
Diffs
-----
trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1105894
trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1105894
trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1105894
trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1105894
trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1105894
trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1105894
trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1105894
trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1105894
trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1105894
trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1105894
trunk/KDE/kdeplasma-addons/applets/frame/urlSettings.ui PRE-CREATION
Diff: http://reviewboard.kde.org/r/3334/diff
Testing
-------
Thanks,
eti
More information about the Plasma-devel
mailing list