Review Request: Initial work on the flexible controller of the Plasma Media Center

[Alessandro Diaferia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3396/#review4680
-----------------------------------------------------------


I like how the MC looks like this way. Please be sure to fix what i pointed out. Of course i'd also wait for at least Marco's suggestions about this work.


/trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h
<http://reviewboard.kde.org/r/3396/#comment4184>

    Please remove whitespaces all aroud the code.



/trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp
<http://reviewboard.kde.org/r/3396/#comment4183>

    Having the browsing widgets only in your panel is just fine imho. You can write a method to enable/disable them in the browser API probably.



/trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp
<http://reviewboard.kde.org/r/3396/#comment4185>

    Why is this needed?



/trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp
<http://reviewboard.kde.org/r/3396/#comment4186>

    As you said in the comment: please remove magic numbers. Put them as static const int s_name at the beginning of this file.



/trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp
<http://reviewboard.kde.org/r/3396/#comment4187>

    What do you really want to achieve with this loop? clear() method can be used to clear a list.



/trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp
<http://reviewboard.kde.org/r/3396/#comment4188>

    same as above



/trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.cpp
<http://reviewboard.kde.org/r/3396/#comment4189>

    This is not the way to go. This layout class should only interact with the API and not with actual and specific implementations such as the MediaController. However i do not see in this code any specific MediaController object created so you can remove this header. Or just revert the specific code if i'm blind :)


- Alessandro


On 2010-03-25 19:01:32, Christophe Olinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3396/
> -----------------------------------------------------------
> 
> (Updated 2010-03-25 19:01:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch extends the controller applet by having 6 different layout modes which are adapted to what the media center is currently used for, i.e. browsing pictures, playing videos, etc. It sends a signal to the containment with the current mode. The containment then relayouts the other applets and configures them for the current Mode. These modes are defined as enum in the libs.
> *The browser no longer has any controls. Those are now in the controller.
> *The controller also has a show/hide playlist button and a toggle autohide button for itself.
> *The different modes do not have sensible functions yet. I also need to work on configuring the applets for each mode, like telling the browser to hide, or the player to show.
> *The controller is not really beautiful. I want animations for show(hide icons. I want the modeswitch button in a "drawer" perhaps. The toggle buttons need effects.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.h 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/browser.cpp 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h 1107457 
>   /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp 1107457 
> 
> Diff: http://reviewboard.kde.org/r/3396/diff
> 
> 
> Testing
> -------
> 
> I tested the controller itself. The actual effect on the other applets when changing modes still needs work.
> 
> 
> Thanks,
> 
> Christophe
> 
>