Review Request: again on webview+scrollwidget

Marco Martin notmart at gmail.com
Thu Mar 25 22:48:46 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3399/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this is 99% the zack's patch he sent yesterday on mailinglist (using scrollwidget for flicking in webview), it fixes some issues regarding the scrollposition being -widget.position.
now flicking works again in both cases (with a widget or webview) fixed also ensureItemVisible, wheelevents are a bit better but still a bit wonky

of course final verdict is from zack ;)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1106404 
  /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1106402 

Diff: http://reviewboard.kde.org/r/3399/diff


Testing
-------


Thanks,

Marco



More information about the Plasma-devel mailing list