Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

[Lukas Appelhans]

Am Mittwoch 24 März 2010 17:47:07 schrieb Ingomar Wesp:
> Hi!
> 
> Thanks for your ongoing support. I really appreciate it.
> 
> Lukas Appelhans wrote:
> > First of all, I agree with pretty much all the points you noted! :) I
> > also have or better had some ideas about how to make the configuration
> > of icon-size/icon-rows cleaner and easier to use (the original idea was
> > from FiNeX, I have to talk to him again :))...
> 
> Are you referring to <https://bugs.kde.org/show_bug.cgi?id=206912>, maybe?
> 
> If you are, I pretty much agree with what FiNeX suggests (in fact, it
> would have even been easier to implement than the behavior that is in the
> patch ;).
> 
> IMHO, an even better way to do it would be to mimic the behavior (and
> configuration options) of the task bar in that regard. That would allow the
> user to explicitly set the maximum number of rows (or columns in vertical
> form factors). It would also be quite flexible for power users who can
> force this number, should they not agree with the default height limit at
> which a new row is generated. Also, it would improve consistency across
> the various widgets.
> 
> If no one objects, I'll gladly implement that (but I'll finish this patch
> first).
Sure, at the moment we also have the option to force a specific size but not 
having it in multiple rows (nookie requested that once I think)... we can 
abandon that though, I doubt anyone actually uses it :) Right? (open question 
to the list)
> 
> > Anyway, I will give the patch a final review when it's finished, but one
> > thing I noticed from a short look was that you use quite a bunch of magic
> > numbers in your code, e.g. "dialogSize.setWidth(dialogSize.width() +
> > 14);" whereas you should rather move the "14" into a const int NUMBER...
> 
> Whoops. This is one of the (probably many) artifacts left over from
> experimenting with different settings. I'll try to get rid of this an other
> nasty things before I submit the next diff.
> 
> BTW (and sorry if this qustion is stupid, but I haven't dwelved far enough
> into the depths of Plasma): Is there any way to get a Plasma::Dialog to
> automatically resize to the preferredSize of its graphicsWidget upon
> change? Because that would be really helpful.
Mmh, I doubt this, but no real clue...
> 
> Alright. So I'll apply the following changes:
> 
> 1.) Replace the configuration setting "visible icons" with something like
> ... "enable dialog" (but that sounds a bit too technical), maybe ... "show
> more icons".
Yup, but then we don't really show more icons when checking this preference...

Mmh... "Enable additional popup", "Show popup for additional icons" etc... I 
have no clue :/ Anyone?
> 
> 2.) Apply the functional changes required for 1).
> 
> 3.) Add some graceful way of handling the empty grid situation.
> 
> 4.) Polish the drop marker so it doesn't hurt to look at it.
Great! :)
> 
> If there are any objections, please don't hesitate to write a quick reply.
> 
> Ah, yes, one more question: Should I append the final patch to the existing
> review request or should I discard this one and create a new one when the
> time comes?
Just append it I think...

Thanks,

Lukas
> 
> Best regards,
> Ingo
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel