Review Request: flicking of WebView with ScrollWidget

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3368/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

after the last modifications by Zack on Scrollwidget, now flicking is managed by ScrollWidget itself, because it's the only way it can safely filter child events..
and since html elements will be done by qraphicsitems, it will probably be necessary to do the same thing in WebView.
this is an early attempt, but doesn't seem to work very well. there is a qgraphicswidget with geometry syncronized with the page contents so flicking it makes the page scroll around.

it's not always correct since is not possible to watch for a change in the zoom level.
things still missing: disabling everything with setDragToScroll and support for multitouch events.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1106404 
  /trunk/KDE/kdelibs/plasma/widgets/webview.h 1106402 
  /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1106402 

Diff: http://reviewboard.kde.org/r/3368/diff


Testing
-------

it seems significantly slower and quite buggy, but i don't see much more ways to do it.

another way would be generalizing scrollwidget to make it possible to set properties in the webview instead of moving the clipped widget into the parent, but it would make it even more complex.

another way could be moving everything back in kineticscroll again, make it visible to the classes that are using it (so won't be possible anymore to use it outside of libplasma) and forward by hand to it sceneeventfilter.

the latter is at the moment the one i'm leaning towards.


Thanks,

Marco