Workaround in WebView...

[Alexis Ménard]

There are two crashes because of this workaround.

One in QGV is fixed and is on its way to 4.6.3

The other is reported :

https://bugs.kde.org/show_bug.cgi?id=227639

It would be nice if the original writer of the workaround can help the
guys of QtWebkit. I'm kinda busy right now.

Next time when adding a workaround please open a bug report in the
upstream project.

On Mon, Mar 22, 2010 at 7:56 PM, Marco Martin <notmart at gmail.com> wrote:
> On Monday 22 March 2010, Marco Martin wrote:
>> On Monday 22 March 2010, Alexis Ménard wrote:
>> > Hello,
>> >
>> >
>> > May i know where was the crash? Because i'm sure the workaround is not
>> > needed anymore...
>> >
>> > QVariant WebView::itemChange(GraphicsItemChange change, const QVariant
>> > &value) {
>> >
>> >     if (change == QGraphicsItem::ItemSceneHasChanged) {
>> >
>> >         //FIXME: QWebPage _requires_ a QWidget view to not crash in
>> >
>> > places such as
>> >
>> >         // WebCore::PopupMenu::show() due to
>> >
>> > hostWindow()->platformPageClient() == NULL
>> >
>> >         // because QWebPage::d->client is NULL
>> >         d->webView->page()->setView(viewFor(this));
>> >
>> >     }
>> >     return QGraphicsWidget::itemChange(change, value);
>> >
>> > }
>> >
>> > Thank you....
>>
>> iirc the crash was opening a combobox in a webpage.
>> right now this workaround causes many other crashes with a quite random
>> behaviour, and one for which Amarok is being beaten quite a lot lately:
>> https://bugs.kde.org/show_bug.cgi?id=227639
>>
>> Cheers,
>> Marco Martin
>
> and by the way.. it doesn't seem to crash anymore wit the hack disabled.
> combobox popups are slightly misplaced (about 50 pixels too high), but  they
> work.
> sooo, can it be removed?
>
> Cheers,
> Marco Martin
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>