Review Request: Add "New Playlist" option to Media Center playlist

[Alessandro Diaferia]

2010/3/18 Shantanu Tushar Jha <jhahoneyk at gmail.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3317/
> -----------------------------------------------------------
>
> Review request for Plasma, Marco Martin and Alessandro Diaferia.
>
>
> Summary
> -------
>
> This patch lets the user to add a new playlist to the Media Center playlist
> collection.
>
>
> Diffs
> -----
>
>  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.h
> 1104231
>  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.cpp
> 1104231
>  trunk/playground/base/plasma/MediaCenterComponents/dataengines/playlist/playlist.cpp
> 1104231
>
> Diff: http://reviewboard.kde.org/r/3317/diff
>
>
> Testing
> -------
>
> Adding new playlists work, so does adding media to the playlists. However,
> Media Player is only able to play media in one playlist. Input needed to
> resolve this - keep player's internal playlist in sync with the selected
> playlist, or tell the player when and what to play according to the playlist
> applet?
>
>
> Thanks,
>
> Shantanu
>
>
The patch looks good to me but i still have to try locally. The issue with
the player only seeing one playlist is just a bug. I probably forgot to look
for playlist changes. The MediaContainment is what you should look at. It
takes care of updating each applet internal state so you just have to
connect to the playlist and make it update the player internal queue
whenever the playlist changes. Hope it helps.

Regards

-- 
Alessandro Diaferia
KDE Developer
KDE e.V. member
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100318/66007eee/attachment-0001.htm