Review Request: Improve Plasma::Dialog border checking, mask updating
Aaron Seigo
aseigo at kde.org
Tue Mar 16 21:40:35 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3306/
-----------------------------------------------------------
(Updated 2010-03-16 20:40:35.751854)
Review request for Plasma.
Changes
-------
init some vars
Summary
-------
This patch splits themeUpdated() into a set of methods that do the border checking and mask updating so that only the necessary work is actually done. The resize and move events now also cooperate in the scheduling of calls to checkBorders (reducing them by 50% or more during resizing). Calls to update(), which trigger full repaints, are also minimized.
Diffs (updated)
-----
/trunk/KDE/kdelibs/plasma/dialog.h 1104111
/trunk/KDE/kdelibs/plasma/dialog.cpp 1104111
Diff: http://reviewboard.kde.org/r/3306/diff
Testing
-------
Thanks,
Aaron
More information about the Plasma-devel
mailing list