Review Request: Shows QIcon inside plasmaengineexplorer when needed and possible

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3283/#review4505
-----------------------------------------------------------

Ship it!


- Aaron


On 2010-03-14 18:25:13, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3283/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 18:25:13)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Quick patch that adds a special case when the data inside the QVariant is convertible to a QIcon.
> Shows the QIcon instead of the text when the data is convertible to a QIcon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp 1103228 
> 
> Diff: http://reviewboard.kde.org/r/3283/diff
> 
> 
> Testing
> -------
> 
> Tested with both tasks data engine and the current version of the data engine for StatusNotifierItem.
> 
> 
> Thanks,
> 
> Matthieu
> 
>