Review Request: Minor cleanups and improvements in the KineticScrolling

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3276/#review4496
-----------------------------------------------------------

Ship it!


well, it seems a quite good improvement :)
there seems only to be a little regression compared to the old one. if the flicking is done on a widget filtered with Scrollwidget::registerAsDragHandle() rather than on the scrollwidget main widget itself, the movement loses all inertia.
can't (still) really figure out since the patch doesn't seem to touch anything related to that, hmmm :/
About put things on kineticscrolling or scrollwidget, i know putting everything in kinetikscrolling makes the code a bit more wonky, but i would like it to be there to recycle it for WebView (and possibly other wdgets someday too) as much effortless as possible.


/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp
<http://reviewboard.kde.org/r/3276/#comment3945>

    braces also on single line ifs


- Marco


On 2010-03-13 21:27:19, Zack Rusin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3276/
> -----------------------------------------------------------
> 
> (Updated 2010-03-13 21:27:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Cleanups and improvements to the KineticScrolling class.
> 
> This code really needs to be in Plasma::ScrollWidget where it's a lot easier to filter child events, but for the time being this patch cleans up the Plasma::KineticScrolling a bit and makes the physics model a little better (still not ideal though). 
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1102194 
>   /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1102194 
> 
> Diff: http://reviewboard.kde.org/r/3276/diff
> 
> 
> Testing
> -------
> 
> In a custom app, mainly vertical flicking.
> 
> 
> Thanks,
> 
> Zack
> 
>